feat: Unit Add sidebar [FC-0114] #2837

ChrisChV · 2026-01-23T22:48:51Z

Description

Implements the new add sidebar.
Which user roles will this change impact? "Course Author",

Supporting information

Github issue: Unit Page: Add Sidebar #2636
Internal ticket: https://tasks.opencraft.com/browse/FAL-4303

Testing instructions

Go to the unit page in a course.
Click the Add button in the new header. Verify that the add sidebar is open.
Create a Video.
Go to the add sidebar.
Create Text from a template.
Go to the add sidebar.
Create an Advanced block.
Test creating other blocks.
Go to the add sidebar and go to the Add Existing tag.
Test adding some components from libraries.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

Any new files are using TypeScript (.ts, .tsx).
Avoid propTypes and defaultProps in any new or modified code.
Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
All new i18n messages in messages.ts files have a description for translators to use.
Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

openedx-webhooks · 2026-01-23T22:48:57Z

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2026-01-23T23:00:30Z

Codecov Report

❌ Patch coverage is 95.78947% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.22%. Comparing base (bb6b2ab) to head (69708bd).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-unit/unit-sidebar/AddSidebar.tsx	93.75%	7 Missing ⚠️
src/editors/containers/ProblemEditor/index.tsx	93.33%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2837    +/-   ##
========================================
  Coverage   95.21%   95.22%            
========================================
  Files        1326     1328     +2     
  Lines       30343    30510   +167     
  Branches     6638     6884   +246     
========================================
+ Hits        28892    29053   +161     
- Misses       1394     1400     +6     
  Partials       57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Existing tab implemented using the ComponentPicker - Basic component implemented in the new tab

navinkarkera

@ChrisChV Overall it looks good.

The add sidebar even works in library sourced units, we should probably disable/hide add button and also have a check in add sidebar to disallow adding components.

navinkarkera · 2026-02-03T05:48:34Z

src/course-unit/unit-sidebar/AddSidebar.tsx

+    <MultiLibraryProvider>
+      <ComponentPicker
+        showOnlyPublished
+        extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']}


@ChrisChV We need to come up with better filter here, it is displaying units, subsections, sections and other components from courses including course blocks.

Suggested change

extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']}

extraFilter={['type = "library_block"']}

Above change works but we need to test it a bit more.

Updated: c16ff58

navinkarkera

@ChrisChV Looks good.

src/course-unit/unit-sidebar/AddSidebar.tsx

src/course-unit/hooks.tsx

bradenmacdonald

LGTM! Please just make the component colors more DRY by refactoring them to use CSS variables (not SCSS variables) and this is good to go as far as I'm concerned.

src/course-unit/unit-sidebar/AddSidebar.tsx

src/generic/block-type-utils/index.scss

src/generic/block-type-utils/constants.ts

bradenmacdonald · 2026-02-06T21:36:36Z

Thanks for those changes! ✅

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 23, 2026

ChrisChV marked this pull request as draft January 23, 2026 22:48

openedx-webhooks added this to Contributions Jan 23, 2026

github-project-automation bot moved this to Needs Triage in Contributions Jan 23, 2026

feat: Unit Add sidebar

c944174

- Existing tab implemented using the ComponentPicker - Basic component implemented in the new tab

ChrisChV force-pushed the chris/FAL-4303-add-sidebar branch from b33cb44 to c944174 Compare January 26, 2026 21:28

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 27, 2026

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jan 27, 2026

ChrisChV added 5 commits January 27, 2026 17:52

feat: Advanced page in add sidebar

0ed65a3

refactor: Move Copy button

c186187

Merge branch 'master' into chris/FAL-4303-add-sidebar

1fb14ee

feat: Problem types templates

af33405

test: Test for the Add Sidebar

c242abd

ChrisChV changed the title ~~feat: Unit Add sidebar~~ feat: Unit Add sidebar [FC-0114] Jan 30, 2026

ChrisChV marked this pull request as ready for review January 30, 2026 01:27

ChrisChV added 3 commits February 2, 2026 17:21

Merge branch 'master' into chris/FAL-4303-add-sidebar

a55a06d

fix: Broken tests and broken oxlint

3b849cc

fix: Broken lint

5fdcc9b

navinkarkera suggested changes Feb 3, 2026

View reviewed changes

ChrisChV added 2 commits February 3, 2026 13:53

fix: Hide add sidebar for units from libraries

c16ff58

fix: broken coverage

ec0e9ae

navinkarkera approved these changes Feb 4, 2026

View reviewed changes

src/course-unit/unit-sidebar/AddSidebar.tsx Outdated Show resolved Hide resolved

src/course-unit/hooks.tsx Outdated Show resolved Hide resolved

fix: nits on the code

1e780ec

ChrisChV requested a review from bradenmacdonald February 4, 2026 19:42

bradenmacdonald approved these changes Feb 5, 2026

View reviewed changes

ChrisChV added 2 commits February 6, 2026 14:18

refactor: Content library components/containers colors

1fce839

refactor: Use classes instead of a function to get icon colors

ecdc485

ChrisChV mentioned this pull request Feb 6, 2026

refactor: Color style classes for content library items #2864

Open

ChrisChV added 2 commits February 6, 2026 15:14

fix: Broken coverage

c77d130

fix: Broken coverage

509453a

Merge branch 'master' into chris/FAL-4303-add-sidebar

69708bd

ChrisChV merged commit 2d5421e into openedx:master Feb 9, 2026
9 of 13 checks passed

github-project-automation bot moved this from Waiting on Author to Done in Contributions Feb 9, 2026

ChrisChV deleted the chris/FAL-4303-add-sidebar branch February 9, 2026 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Unit Add sidebar [FC-0114] #2837

feat: Unit Add sidebar [FC-0114] #2837

ChrisChV commented Jan 23, 2026 •

edited

Loading

Uh oh!

openedx-webhooks commented Jan 23, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

navinkarkera left a comment

Uh oh!

navinkarkera Feb 3, 2026

Uh oh!

ChrisChV Feb 3, 2026

Uh oh!

navinkarkera left a comment

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']}
	extraFilter={['type = "library_block"']}

feat: Unit Add sidebar [FC-0114] #2837

feat: Unit Add sidebar [FC-0114] #2837

Conversation

ChrisChV commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Other information

Best Practices Checklist

Uh oh!

openedx-webhooks commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

navinkarkera Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

ChrisChV Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

navinkarkera left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ChrisChV commented Jan 23, 2026 •

edited

Loading

openedx-webhooks commented Jan 23, 2026 •

edited

Loading

codecov bot commented Jan 23, 2026 •

edited

Loading